git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/6] update_unicode.sh: pin the uniset repo to a known good commit

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 15, 2016, 17:50 UTC
Message-ID
<xmqq4m25w07k.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<1481795248.4090.15.camel@kaarsemaker.net>
Dennis Kaarsemaker <dennis@kaarsemaker.net> writes:
Show 10 quoted lines
> On Wed, 2016-12-14 at 00:31 +0100, Beat Bolli wrote:
>> +       ( cd uniset && git checkout 4b186196dd )
>
> Micronit, but this is perhaps better written as
>
> git -C uniset checkout 4b186196dd
>
> to avoid the subshell and cd.
>
> D.

In the context of this script, I would say that is not even a micronit. It is "you could do this if you wanted to".

Previous: Dennis KaarsemakerNext: Beat Bolli
Message 10 of 12 in “unicode_width.h: update the width tables to Unicode 9.0”
  1. 0/6 unicode_width.h: update the width tables to Unicode 9.0Beat Bolli, Dec 13, 2016
  2. 6/6 unicode_width.h: update the width tables to Unicode 9.0Beat Bolli, Dec 13, 2016
  3. 4/6 update-unicode.sh: automatically download newer definition filesBeat Bolli, Dec 13, 2016
  4. Beat BolliDec 14, 2016
  5. Junio C HamanoDec 14, 2016
  6. 2/6 update_unicode.sh: remove an unnecessary subshell levelBeat Bolli, Dec 13, 2016
  7. 5/6 update_unicode.sh: remove the plane filterBeat Bolli, Dec 13, 2016
  8. 3/6 update_unicode.sh: pin the uniset repo to a known good commitBeat Bolli, Dec 13, 2016
  9. Dennis KaarsemakerDec 15, 2016
  10. Junio C HamanoDec 15, 2016
  11. 1/6 update_unicode.sh: move it into contrib/update-unicodeBeat Bolli, Dec 13, 2016
  12. Junio C HamanoDec 14, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.