git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 4/6] update-unicode.sh: automatically download newer definition files

From
Beat Bolli <dev+git@drbeat.li>
Date
Dec 13, 2016, 23:31 UTC
Message-ID
<1481671904-1143-5-git-send-email-dev+git@drbeat.li>
In-Reply-To
<1481671904-1143-1-git-send-email-dev+git@drbeat.li>

Checking just for the unicode data files' existence is not sufficient; we should also download them if a newer version exists on the Unicode consortium's servers. Option -N of wget does this nicely for us.

Reviewed-by: Torsten Bögershausen <tboegi@web.de>
Signed-off-by: Beat Bolli <dev+git@drbeat.li>
---
 contrib/update-unicode/update_unicode.sh | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/contrib/update-unicode/update_unicode.sh b/contrib/update-unicode/update_unicode.sh
index 9f1bf31..56871a1 100755
--- a/contrib/update-unicode/update_unicode.sh
+++ b/contrib/update-unicode/update_unicode.sh
@@ -8,12 +8,8 @@
 cd "$(dirname "$0")"
 UNICODEWIDTH_H=$(git rev-parse --show-toplevel)/unicode_width.h
 
-if ! test -f UnicodeData.txt; then
-	wget http://www.unicode.org/Public/UCD/latest/ucd/UnicodeData.txt
-fi &&
-if ! test -f EastAsianWidth.txt; then
-	wget http://www.unicode.org/Public/UCD/latest/ucd/EastAsianWidth.txt
-fi &&
+wget -N http://www.unicode.org/Public/UCD/latest/ucd/UnicodeData.txt \
+	http://www.unicode.org/Public/UCD/latest/ucd/EastAsianWidth.txt &&
 if ! test -d uniset; then
 	git clone https://github.com/depp/uniset.git &&
 	( cd uniset && git checkout 4b186196dd )
-- 
2.7.2
Previous: Beat BolliNext: Beat Bolli
Message 3 of 12 in “unicode_width.h: update the width tables to Unicode 9.0”
  1. 0/6 unicode_width.h: update the width tables to Unicode 9.0Beat Bolli, Dec 13, 2016
  2. 6/6 unicode_width.h: update the width tables to Unicode 9.0Beat Bolli, Dec 13, 2016
  3. 4/6 update-unicode.sh: automatically download newer definition filesBeat Bolli, Dec 13, 2016
  4. Beat BolliDec 14, 2016
  5. Junio C HamanoDec 14, 2016
  6. 2/6 update_unicode.sh: remove an unnecessary subshell levelBeat Bolli, Dec 13, 2016
  7. 5/6 update_unicode.sh: remove the plane filterBeat Bolli, Dec 13, 2016
  8. 3/6 update_unicode.sh: pin the uniset repo to a known good commitBeat Bolli, Dec 13, 2016
  9. Dennis KaarsemakerDec 15, 2016
  10. Junio C HamanoDec 15, 2016
  11. 1/6 update_unicode.sh: move it into contrib/update-unicodeBeat Bolli, Dec 13, 2016
  12. Junio C HamanoDec 14, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.