git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-clone --config order & fetching extra refs during initial clone

From
Junio C Hamano <gitster@pobox.com>
Date
May 9, 2017, 01:33 UTC
Message-ID
<xmqq4lwu7r0s.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170503202224.arjszzbruxjgpkt5@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 19 quoted lines
> Good point. We can't really consider clone to be a blind "init + config
> + fetch + checkout" because those middle two steps sometimes overlap
> each other.  It really does need to be its own beast.
> ...
> The right solution there is probably pushing that logic down into the
> transport layer. Or at the very least abstracting it into a function so
> that both clone and fetch can call it without replicating the logic.
>
>> My patch deals with 'remote.<name>.refspec', i.e. 'remote->fetch'.
>> Apparently some extra care is necessary for 'remote.<name>.tagOpt' and
>> 'remote->fetch_tags', too.  Perhaps there are more, I haven't checked
>> again, and maybe we'll add similar config variables in the future.  So
>> I don't think that dealing with such config variables one by one in
>> 'git clone', too, is the right long-term solution...  but perhaps it's
>> sufficient for the time being?
>
> I think your patch is a strict improvement and we don't need to hold up
> waiting for a perfect fix (and because of the --single-branch thing you
> mentioned, this may be the best we can do anyway).

OK, so where does this patch stand now? It already is too late for the upcoming release, but should we merge it to 'next' once the release is made, cook it in 'next' and shoot for the next release as-is, or do we want to allow minor tweaks before it hits 'next'?

Thanks.
Previous: Sebastian SchuberthNext: Jeff King
Message 11 of 15 in “git-clone --config order & fetching extra refs during initial clone”
  1. Robin H. JohnsonFeb 25, 2017
  2. Jeff KingFeb 25, 2017
  3. Jeff KingFeb 25, 2017
  4. Junio C HamanoFeb 27, 2017
  5. Jeff KingFeb 27, 2017
  6. SZEDER GáborMar 11, 2017
  7. Jeff KingMar 15, 2017
  8. SZEDER GáborMay 3, 2017
  9. Jeff KingMay 3, 2017
  10. Sebastian SchuberthMay 4, 2017
  11. Junio C HamanoMay 9, 2017
  12. Jeff KingMay 9, 2017
  13. Jeff KingMay 9, 2017
  14. Junio C HamanoMay 9, 2017
  15. Ævar Arnfjörð BjarmasonMay 4, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.