Re: git-clone --config order & fetching extra refs during initial clone

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: May 4, 2017, 06:57 UTC
Message-ID: <9a4e4354-d94e-c914-3ac2-309dd5e7896b@gmail.com>
In-Reply-To: <20170503202224.arjszzbruxjgpkt5@sigill.intra.peff.net>

On 5/3/2017 22:22, Jeff King wrote:

Show 11 quoted lines

>> My patch deals with 'remote.<name>.refspec', i.e. 'remote->fetch'.
>> Apparently some extra care is necessary for 'remote.<name>.tagOpt' and
>> 'remote->fetch_tags', too.  Perhaps there are more, I haven't checked
>> again, and maybe we'll add similar config variables in the future.  So
>> I don't think that dealing with such config variables one by one in
>> 'git clone', too, is the right long-term solution...  but perhaps it's
>> sufficient for the time being?
> 
> I think your patch is a strict improvement and we don't need to hold up
> waiting for a perfect fix (and because of the --single-branch thing you
> mentioned, this may be the best we can do anyway).

I agree. Let's fix one thing at a time, and not make this a overarching "account for all previously ignored config variables during clone" fix. Esp. as specifying the refspec is explicitly documented to work durig clone [1] I think we should get this in ASAP.

Thanks for your work so far!

[1] https://git-scm.com/docs/git-clone#git-clone---configltkeygtltvaluegt

Regards, Sebastian