git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/2] Incremental rewrite of git-submodules

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 16, 2018, 19:32 UTC
Message-ID
<xmqq4lnlvbty.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20180114211529.6391-1-pc44800@gmail.com>
Prathamesh Chavan <pc44800@gmail.com> writes:
Show 23 quoted lines
> Changes in v3:
>
> * For the variables: super_config_url and sub_origin_url, xstrdup() was used
>   while assigning "" to them, before freeing.
>
> * In case of the function deinit_submodule, since the orignal code doesn't die
>   upon failure of the function mkdir(), printf was used instead of die_errno.
>
> As before you can find this series at:
> https://github.com/pratham-pc/git/commits/patch-series-2
>
> And its build report is available at:
> https://travis-ci.org/pratham-pc/git/builds/
> Branch: patch-series-2
> Build #197
>
> Prathamesh Chavan (2):
>   submodule: port submodule subcommand 'sync' from shell to C
>   submodule: port submodule subcommand 'deinit' from shell to C
>
>  builtin/submodule--helper.c | 340 ++++++++++++++++++++++++++++++++++++++++++++
>  git-submodule.sh            | 112 +--------------
>  2 files changed, 342 insertions(+), 110 deletions(-)
Looks sensible.  Thanks.
Previous: Prathamesh Chavan
Message 19 of 19 in “Incremental rewrite of git-submodules”
  1. 0/2 Incremental rewrite of git-submodulesPrathamesh Chavan, Jan 9, 2018
  2. 1/2 submodule: port submodule subcommand 'sync' from shell to CPrathamesh Chavan, Jan 9, 2018
  3. Junio C HamanoJan 9, 2018
  4. 2/2 submodule: port submodule subcommand 'deinit' from shell to CPrathamesh Chavan, Jan 9, 2018
  5. Junio C HamanoJan 9, 2018
  6. Prathamesh ChavanJan 10, 2018
  7. Junio C HamanoJan 10, 2018
  8. Stefan BellerJan 9, 2018
  9. Brandon WilliamsJan 9, 2018
  10. 0/2 Incremental rewrite of git-submodulesPrathamesh Chavan, Jan 11, 2018
  11. 2/2 submodule: port submodule subcommand 'deinit' from shell to CPrathamesh Chavan, Jan 11, 2018
  12. Junio C HamanoJan 11, 2018
  13. 1/2 submodule: port submodule subcommand 'sync' from shell to CPrathamesh Chavan, Jan 11, 2018
  14. Junio C HamanoJan 11, 2018
  15. Junio C HamanoJan 11, 2018
  16. 0/2 Incremental rewrite of git-submodulesPrathamesh Chavan, Jan 14, 2018
  17. 1/2 submodule: port submodule subcommand 'sync' from shell to CPrathamesh Chavan, Jan 14, 2018
  18. 2/2 submodule: port submodule subcommand 'deinit' from shell to CPrathamesh Chavan, Jan 14, 2018
  19. Junio C HamanoJan 16, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.