Re: [PATCH v1 0/2] Incremental rewrite of git-submodules
- From
Stefan Beller <sbeller@google.com>
- Date
- Jan 9, 2018, 19:25 UTC
- Message-ID
- <CAGZ79kZs9fNOZ0wCahRrwRn8k3rHOAXCchyLmb0AaC_qCNFx4A@mail.gmail.com>
- In-Reply-To
- <20180109175703.4793-1-pc44800@gmail.com>
On Tue, Jan 9, 2018 at 9:57 AM, Prathamesh Chavan <pc44800@gmail.com> wrote:
Show 23 quoted lines
> The patches [1] and [2] concerning the porting of submodule > subcommands: sync and deinit were updated in accoudance with > the changes made in one of such similar portings made earlier > for submodule subcommand status[3]. Following are the changes > made: > > * It was observed that the number of params increased a lot due to flags > like quiet, recursive, cached, etc, and keeping in mind the future > subcommand's ported functions as well, a single unsigned int called > flags was introduced to store all of these flags, instead of having > parameter for each one. > > * To accomodate the possiblity of a direct call to the functions > deinit_submodule() and sync_submodule(), callback functions were > introduced. > > As before you can find this series at: > https://github.com/pratham-pc/git/commits/patch-series-2 > > And its build report is available at: > https://travis-ci.org/pratham-pc/git/builds/ > Branch: patch-series-2 > Build #195
Cool!
I have reviewed both patches and found them good to apply;
Thanks, Stefan