git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] t7505: Add tests for cherry-pick and rebase -i/-p

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 23, 2018, 18:41 UTC
Message-ID
<xmqq4lncifjh.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20180123102420.19911-2-phillip.wood@talktalk.net>
Phillip Wood <phillip.wood@talktalk.net> writes:
Show 41 quoted lines
> @@ -31,17 +63,40 @@ mkdir -p "$HOOKDIR"
>  echo "#!$SHELL_PATH" > "$HOOK"
>  cat >> "$HOOK" <<'EOF'
>  
> +GIT_DIR=$(git rev-parse --git-dir)
> +if test -d "$GIT_DIR/rebase-merge"
> +then
> +  rebasing=1
> +else
> +  rebasing=0
> +fi
> +
> +get_last_cmd () {
> +  tail -n1 "$GIT_DIR/rebase-merge/done" | {
> +    read cmd id _
> +    git log --pretty="[$cmd %s]" -n1 $id
> +  }
> +}
> +
>  if test "$2" = commit; then
> -  source=$(git rev-parse "$3")
> +  if test $rebasing = 1
> +  then
> +    source="$3"
> +  else
> +    source=$(git rev-parse "$3")
> +  fi
>  else
>    source=${2-default}
>  fi
> -if test "$GIT_EDITOR" = :; then
> -  sed -e "1s/.*/$source (no editor)/" "$1" > msg.tmp
> +test "$GIT_EDITOR" = : && source="$source (no editor)"
> +
> +if test $rebasing = 1
> +then
> +  echo "$source $(get_last_cmd)" >"$1"
>  else
>    sed -e "1s/.*/$source/" "$1" > msg.tmp
> +  mv msg.tmp "$1"
>  fi

It is somewhat irritating that indentation is screwed up in this part of the file. Can we not make it even worse?

Previous: Phillip WoodNext: Junio C Hamano
Message 12 of 23 in “prepare-commit-msg hook no longer run for cherry-pick?”
  1. Dmitry TorokhovJan 5, 2018
  2. Dmitry TorokhovJan 10, 2018
  3. Junio C HamanoJan 10, 2018
  4. Dmitry TorokhovJan 10, 2018
  5. Junio C HamanoJan 10, 2018
  6. 0/2 sequencer: run 'prepare-commit-msg' hookPhillip Wood, Jan 19, 2018
  7. 1/2 t7505: Add tests for cherry-pick and rebase -i/-pPhillip Wood, Jan 19, 2018
  8. Eric SunshineJan 20, 2018
  9. 2/2 sequencer: run 'prepare-commit-msg' hookPhillip Wood, Jan 19, 2018
  10. 0/2 sequencer: run 'prepare-commit-msg' hook​Phillip Wood, Jan 23, 2018
  11. 1/2 t7505: Add tests for cherry-pick and rebase -i/-pPhillip Wood, Jan 23, 2018
  12. Junio C HamanoJan 23, 2018
  13. Junio C HamanoJan 23, 2018
  14. 2/2 sequencer: run 'prepare-commit-msg' hookPhillip Wood, Jan 23, 2018
  15. 0/3 sequencer: run 'prepare-commit-msg' hookPhillip Wood, Jan 24, 2018
  16. 3/3 sequencer: run 'prepare-commit-msg' hookPhillip Wood, Jan 24, 2018
  17. Ramsay JonesJan 24, 2018
  18. Junio C HamanoJan 24, 2018
  19. Phillip WoodJan 25, 2018
  20. Johannes SchindelinJan 29, 2018
  21. 1/3 t7505: style fixesPhillip Wood, Jan 24, 2018
  22. 2/3 t7505: Add tests for cherry-pick and rebase -i/-pPhillip Wood, Jan 24, 2018
  23. Eric SunshineJan 24, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.