Re: [PATCH v3 3/3] sequencer: run 'prepare-commit-msg' hook

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 29, 2018, 23:06 UTC
Message-ID: <nycvar.QRO.7.76.6.1801300004350.35@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
In-Reply-To: <20180124123422.10637-4-phillip.wood@talktalk.net>

Hi Phillip,

On Wed, 24 Jan 2018, Phillip Wood wrote:

Show 12 quoted lines

> diff --git a/sequencer.h b/sequencer.h
> index 24401b07d57b7ca875dea939f465f3e6cf1162a5..e45b178dfc41d723bf186f20674c4515d7c7fa00 100644
> --- a/sequencer.h
> +++ b/sequencer.h
> @@ -1,6 +1,7 @@
>  #ifndef SEQUENCER_H
>  #define SEQUENCER_H
>  
> +const char *git_path_commit_editmsg(void);
>  const char *git_path_seq_dir(void);
>  
>  #define APPEND_SIGNOFF_DEDUP (1u << 0)

I would rather have stuck this into `commit.h` and `commit.c`, but it does not really matter all that much. The rest looks good (if a little verbose on the test front, I think testing just the cherry-pick would have exercised the code path enough).

All three patches are Reviewed-by: me.

Ciao, Dscho