Re: [PATCH 0/2] update-index doc: note new caveats in 2.17

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 9, 2018, 21:40 UTC
Message-ID: <xmqq4lmpx2oa.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180209210431.409-1-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> When users upgrade to 2.17 they're going to have git yelling at them
> (as my users did) on existing checkouts, with no indication whatsoever
> that it's due to the UC or how to fix it.

Wait. Are you saying that the new warning is "warning" against a condition that is not an error?

> ... doesn't it only warn under that mode? I.e.:
>
>     -"could not open directory '%s'")
>     +"core.untrackedCache: could not open directory '%s'")

For example, if it attempts to open a directory which does *not* have to exist, and sees an error from opendir() due to ENOENT, then I do not think it should be giving a warning. If we positively know that a directory should exist there and we cannot open it, of course we should warn. Also, if we know a directory should be readable when it exists, then we should be warning when we see an error other than ENOENT.

So...