git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Jan 2018, #04; Wed, 31)

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Feb 1, 2018, 11:05 UTC
Message-ID
<87mv0tm0l7.fsf@evledraar.booking.com>
In-Reply-To
<xmqqd11pr0he.fsf@gitster-ct.c.googlers.com>
On Thu, Feb 01 2018, Junio C. Hamano jotted:
Show 16 quoted lines
> * ab/wildmatch-tests (2018-01-30) 10 commits
>  - wildmatch test: mark test as EXPENSIVE_ON_WINDOWS
>  - test-lib: add an EXPENSIVE_ON_WINDOWS prerequisite
>  - wildmatch test: create & test files on disk in addition to in-memory
>  - wildmatch test: perform all tests under all wildmatch() modes
>  - wildmatch test: use test_must_fail, not ! for test-wildmatch
>  - wildmatch test: remove dead fnmatch() test code
>  - wildmatch test: use a paranoia pattern from nul_match()
>  - wildmatch test: don't try to vertically align our output
>  - wildmatch test: use more standard shell style
>  - wildmatch test: indent with tabs, not spaces
>
>  More tests for wildmatch functions.
>
>  Expecting an update.
>  cf. <87vaga9mgf.fsf@evledraar.gmail.com>

The 2018-01-30 series is the update mentioned in 87vaga9mgf.fsf@evledraar.gmail.com. You probably noticed this / just didn't adjust the note since you queued in in pu already, but just in case: the known issues in it have been resolved, but hopefully Johannes Schindelin can test it on Windows & report.

Show 10 quoted lines
> * nd/fix-untracked-cache-invalidation (2018-01-24) 5 commits
>  - dir.c: stop ignoring opendir() error in open_cached_dir()
>  - update-index doc: note a fixed bug in the untracked cache
>  - dir.c: fix missing dir invalidation in untracked code
>  - dir.c: avoid stat() in valid_cached_dir()
>  - status: add a failing test showing a core.untrackedCache bug
>
>  Some bugs around "untracked cache" feature have been fixed.
>
>  Will merge to 'next'.

It must be Murphy's law or something, but even though the bug has been there for years I just had some internal users again run into the bug this fixes, so I'm building an internal v2.16.1 + custom patches (this included).

Show 11 quoted lines
> * ab/sha1dc-build (2017-12-12) 4 commits
>  . Makefile: use the sha1collisiondetection submodule by default
>  - sha1dc_git.h: re-arrange an ifdef chain for a subsequent change
>  - Makefile: under "make dist", include the sha1collisiondetection submodule
>  - Makefile: don't error out under DC_SHA1_EXTERNAL if DC_SHA1_SUBMODULE=auto
>
>  Push the submodule version of collision-detecting SHA-1 hash
>  implementation a bit harder on builders.
>
>  The earlier two may make sense, but leaning toward rejecting the last step.
>  cf. <xmqqk1xw6c24.fsf@gitster.mtv.corp.google.com>

This has been lingering for a long time. I think it makes sense just to merge the first 3 down and then we can discuss 4/4 in another submission. [12]/4 solve real bugs we have now, 3/4 is harmless to merge down (and makes 4/4 smaller when we get around to discussing it again), it's just 4/4 that's been stalling this.

Do you want to peel of 4/4 and just keep 1-3 should I submit another version without 4/4?

Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 22 in “What's cooking in git.git (Jan 2018, #04; Wed, 31)”
  1. Junio C HamanoFeb 1, 2018
  2. Ævar Arnfjörð BjarmasonFeb 1, 2018
  3. Junio C HamanoFeb 2, 2018
  4. Johannes SchindelinFeb 9, 2018
  5. Ævar Arnfjörð BjarmasonFeb 9, 2018
  6. Ævar Arnfjörð BjarmasonFeb 1, 2018
  7. Junio C HamanoFeb 2, 2018
  8. Ævar Arnfjörð BjarmasonFeb 2, 2018
  9. Ævar Arnfjörð BjarmasonFeb 9, 2018
  10. Junio C HamanoFeb 9, 2018
  11. 0/2 update-index doc: note new caveats in 2.17Ævar Arnfjörð Bjarmason, Feb 9, 2018
  12. 2/2 update-index doc: note the caveat with "could not open..."Ævar Arnfjörð Bjarmason, Feb 9, 2018
  13. 1/2 update-index doc: note a fixed bug in the untracked cacheÆvar Arnfjörð Bjarmason, Feb 9, 2018
  14. Junio C HamanoFeb 9, 2018
  15. Ævar Arnfjörð BjarmasonFeb 9, 2018
  16. Junio C HamanoFeb 9, 2018
  17. Ævar Arnfjörð BjarmasonFeb 9, 2018
  18. Junio C HamanoFeb 9, 2018
  19. Ævar Arnfjörð BjarmasonFeb 9, 2018
  20. Duy NguyenFeb 10, 2018
  21. Ævar Arnfjörð BjarmasonFeb 11, 2018
  22. Duy NguyenFeb 12, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.