Re: [PATCH 2/2] completion: simplify _git_notes

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 7, 2018, 18:51 UTC
Message-ID: <xmqq4llr1zy3.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180307010843.3503-1-szeder.dev@gmail.com>

SZEDER Gábor <szeder.dev@gmail.com> writes:

> That works fine, but this would work just as well and has one less
> case arm:

OK, I missed that "obvious optimization" opportunity. I agree that would work.

Show 14 quoted lines

>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index ab80f4e6e8..038af63c1a 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1839,6 +1839,8 @@ _git_notes ()
>  	*,--*)
>  		__gitcomp_builtin notes_$subcommand
>  		;;
> +	prune,*)
> +		;;
>  	*)
>  		case "$prev" in
>  		-m|-F)