git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 4/4] completion: more subcommands in _git_notes()

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Mar 7, 2018, 01:05 UTC
Message-ID
<20180307010504.9289-5-pclouds@gmail.com>
In-Reply-To
<20180307010504.9289-1-pclouds@gmail.com>

Two subcommands are added for completion: merge and get-ref. get-ref is more like plumbing. But since it does not share the prefix with any other subcommands, it won't slow anybody down.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 contrib/completion/git-completion.bash | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index dc3ec43b65..2e30950299 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1815,7 +1815,7 @@ _git_name_rev ()
 
 _git_notes ()
 {
-	local subcommands='add append copy edit list prune remove show'
+	local subcommands='add append copy edit get-ref list merge prune remove show'
 	local subcommand="$(__git_find_on_cmdline "$subcommands")"
 
 	case "$subcommand,$cur" in
@@ -1838,7 +1838,7 @@ _git_notes ()
 	*,--*)
 		__gitcomp_builtin notes_$subcommand
 		;;
-	prune,*)
+	prune,*|get-ref,*)
 		# this command does not take a ref, do not complete it
 		;;
 	*)
-- 
2.16.2.785.g429c04a1b9
Previous: Nguyễn Thái Ngọc Duy
Message 15 of 15 in “nd/parseopt-completion fixups”
  1. 0/2 nd/parseopt-completion fixupsNguyễn Thái Ngọc Duy, Mar 3, 2018
  2. 1/2 completion: don't set PARSE_OPT_NOCOMPLETE on --rerere-autoupdateNguyễn Thái Ngọc Duy, Mar 3, 2018
  3. Eric SunshineMar 3, 2018
  4. Phillip WoodMar 6, 2018
  5. 2/2 completion: simplify _git_notesNguyễn Thái Ngọc Duy, Mar 3, 2018
  6. SZEDER GáborMar 3, 2018
  7. SZEDER GáborMar 3, 2018
  8. Junio C HamanoMar 6, 2018
  9. SZEDER GáborMar 7, 2018
  10. Junio C HamanoMar 7, 2018
  11. 0/4 nd/parseopt-completion fixupsNguyễn Thái Ngọc Duy, Mar 7, 2018
  12. 1/4 completion: don't set PARSE_OPT_NOCOMPLETE on --rerere-autoupdateNguyễn Thái Ngọc Duy, Mar 7, 2018
  13. 2/4 completion: simplify _git_notesNguyễn Thái Ngọc Duy, Mar 7, 2018
  14. 3/4 completion: complete --{reuse,reedit}-message= for all notes subcmdsNguyễn Thái Ngọc Duy, Mar 7, 2018
  15. 4/4 completion: more subcommands in _git_notes()Nguyễn Thái Ngọc Duy, Mar 7, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.