git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Do not fail test if '.' is part of $PATH

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 3, 2018, 00:29 UTC
Message-ID
<xmqq4lbviha2.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20181201193822.GA28918@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> Since the test is ultimately checking "can we run should-not-run from
> the current directory", might it be simpler to actually try that as the
> precondition? I.e., something like:
> ...

A nice egg of columbus. It also would save us from mischievous users who have should-not-run somewhere no the $PATH that outputs the string we expect (no, I do not think it is a common thing to do; I am just saying that the solution covers such an extremely stupid case without special casing).

Previous: Jeff KingNext: Junio C Hamano
Message 3 of 4 in “Do not fail test if '.' is part of $PATH”
  1. Do not fail test if '.' is part of $PATHH.Merijn Brand, Dec 1, 2018
  2. Jeff KingDec 1, 2018
  3. Junio C HamanoDec 3, 2018
  4. Junio C HamanoDec 3, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.