Re: [PATCHv2] git-p4: ticket expiry test: use a fake p4 to avoid use of 'sleep'

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 9, 2019, 18:06 UTC
Message-ID: <xmqq4l9ckfab.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190208201445.GB10587@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 10 quoted lines

> On Fri, Feb 08, 2019 at 07:02:31PM +0000, Luke Diamand wrote:
>> +# create a fake version of "p4" which returns a TicketExpiration based
>> +# on $EXPIRY, for testing login expiration
>> +create_fake_p4() {
>> +	(
>> +		cd "$git" && mkdir expire-p4 &&
>> +		cat >>expire-p4/p4 <<-EOF &&
>> +		#!/usr/bin/python
>
> I think this should be $PYTHON_PATH.

OK.

Luke, I think our mails / work crossed and the tip of 'master' already has a removal. Please make this into a separate patch that adds (or, resurrects with an improved version) the test for the next cycle.

Thanks.