Re: [PATCHv2] git-p4: ticket expiry test: use a fake p4 to avoid use of 'sleep'

From: Luke Diamand <luke@diamand.org>
Date: Feb 9, 2019, 19:26 UTC
Message-ID: <CAE5ih7_UTONAK5YCj_xYAa-d3zts8RUSkaAFtixa9exnxG8acg@mail.gmail.com>
In-Reply-To: <xmqq4l9ckfab.fsf@gitster-ct.c.googlers.com>

On Sat, 9 Feb 2019 at 18:06, Junio C Hamano <gitster@pobox.com> wrote:

Show 20 quoted lines

>
> SZEDER Gábor <szeder.dev@gmail.com> writes:
>
> > On Fri, Feb 08, 2019 at 07:02:31PM +0000, Luke Diamand wrote:
> >> +# create a fake version of "p4" which returns a TicketExpiration based
> >> +# on $EXPIRY, for testing login expiration
> >> +create_fake_p4() {
> >> +    (
> >> +            cd "$git" && mkdir expire-p4 &&
> >> +            cat >>expire-p4/p4 <<-EOF &&
> >> +            #!/usr/bin/python
> >
> > I think this should be $PYTHON_PATH.
>
> OK.
>
> Luke, I think our mails / work crossed and the tip of 'master'
> already has a removal.  Please make this into a separate patch that
> adds (or, resurrects with an improved version) the test for the next
> cycle.

OK, thanks!