Re: [PATCH v3 2/8] git-p4: add failing test for "git-p4: match branches case insensitively if configured"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 3, 2019, 07:10 UTC
- Message-ID
- <xmqq4l7ftvgl.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20190402120537.GK32732@szeder.dev>
SZEDER Gábor <szeder.dev@gmail.com> writes:
> I wonder whether it would be worth amending 07353d9042 to keep > 'kill_p4d' around as a wrapper around 'stop_and_cleanup_p4d' for the > time being.
I think renaming was the right thing to do; "show --cc" shows that the post-image lives in the new world order where calling kill_p4d is not usually needed clearly with a hunk that replaces kill_p4d (which only existed in the old world) with stop_and_cleanup (which exists only in the new world).
Will redo the merge and teach my rerere database.
Thanks.