[PATCH v2 7/7] git-p4: respect excluded paths when detecting branches
- From
- Mazo, Andrey <amazo@checkvideo.com>
- Date
- Mar 21, 2019, 22:33 UTC
- Message-ID
- <758d8e84868edc4b53c382a74655048d69d187de.1553207234.git.amazo@checkvideo.com>
- In-Reply-To
- <cover.1553207234.git.amazo@checkvideo.com>
Currently, excluded paths are only handled in the following cases: * no branch detection; * branch detection with using clientspec.
However, excluded paths are not respected in case of branch detection without using clientspec.
Fix this by consulting the list of excluded paths when splitting files across branches.
Signed-off-by: Andrey Mazo <amazo@checkvideo.com> --- git-p4.py | 3 +-- t/t9801-git-p4-branch.sh | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/git-p4.py b/git-p4.py index 162877aa82..148ea6f1b0 100755 --- a/git-p4.py +++ b/git-p4.py @@ -2708,12 +2708,11 @@ def splitFilesIntoBranches(self, commit): branches = {} fnum = 0 while "depotFile%s" % fnum in commit: path = commit["depotFile%s" % fnum] - found = [p for p in self.depotPaths - if p4PathStartsWith(path, p)] + found = self.isPathWanted(path) if not found: fnum = fnum + 1 continue file = {} diff --git a/t/t9801-git-p4-branch.sh b/t/t9801-git-p4-branch.sh index 4729f470b2..62a3929d8e 100755 --- a/t/t9801-git-p4-branch.sh +++ b/t/t9801-git-p4-branch.sh @@ -410,11 +410,11 @@ test_expect_failure 'git p4 clone file subset branch' ' test_path_is_missing file3 ) ' # Check that excluded files are omitted during import -test_expect_failure 'git p4 clone complex branches with excluded files' ' +test_expect_success 'git p4 clone complex branches with excluded files' ' test_when_finished cleanup_git && test_create_repo "$git" && ( cd "$git" && git config git-p4.branchList branch1:branch2 &&
-- 2.19.2