git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] git stash pop --quiet deletes files in git 2.24.0

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 13, 2019, 13:31 UTC
Message-ID
<xmqq4kz7c37i.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20191113111539.GA3047@cat>
Thomas Gummerer <t.gummerer@gmail.com> writes:
Show 18 quoted lines
>> ...  This may want to become
>> 
>> 	git rev-parse --verify :file &&
>> 
>> or
>> 
>> 	git show :file >actual && echo bar >expect &&
>> 	test_cmp expect actual &&
>> 
>> perhaps?
>
> Hmm I just copy-pasted this from somewhere else in this test file.
> I'll add a preparatory patch getting rid of "$(git command substitution)"
> as I don't believe Denton got to t3903 yet.
>
> There's some more opportunities for modernization of this test file,
> but I refrained from doing that to not blow up this bug fix series too
> much.

It is very much appreciated that you aimed to keep the topic focused on the fixing. What I meant was merely to avoid making things worse by adding more of $(git command substitution), not cleaning up the existing ones.

Thanks.
Previous: Thomas GummererNext: Thomas Gummerer
Message 9 of 13 in “[BUG] git stash pop --quiet deletes files in git 2.24.0”
  1. Grzegorz RajchmanNov 7, 2019
  2. Thomas GummererNov 7, 2019
  3. Junio C HamanoNov 8, 2019
  4. Thomas GummererNov 8, 2019
  5. Junio C HamanoNov 10, 2019
  6. Thomas GummererNov 11, 2019
  7. Junio C HamanoNov 12, 2019
  8. Thomas GummererNov 13, 2019
  9. Junio C HamanoNov 13, 2019
  10. stash: make sure we have a valid index before writing itThomas Gummerer, Nov 13, 2019
  11. Junio C HamanoNov 14, 2019
  12. 1/2 t3903: avoid git commands inside command substitutionThomas Gummerer, Nov 13, 2019
  13. 2/2 stash: make sure we have a valid index before writing itThomas Gummerer, Nov 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.