From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 13 Nov 2019 13:31:45 GMT
Subject: Re: [BUG] git stash pop --quiet deletes files in git 2.24.0
Message-ID: <xmqq4kz7c37i.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20191113111539.GA3047@cat>

Thomas Gummerer <t.gummerer@gmail.com> writes:

>> ...  This may want to become
>> 
>> 	git rev-parse --verify :file &&
>> 
>> or
>> 
>> 	git show :file >actual && echo bar >expect &&
>> 	test_cmp expect actual &&
>> 
>> perhaps?
>
> Hmm I just copy-pasted this from somewhere else in this test file.
> I'll add a preparatory patch getting rid of "$(git command substitution)"
> as I don't believe Denton got to t3903 yet.
>
> There's some more opportunities for modernization of this test file,
> but I refrained from doing that to not blow up this bug fix series too
> much.

It is very much appreciated that you aimed to keep the topic focused
on the fixing.  What I meant was merely to avoid making things worse
by adding more of $(git command substitution), not cleaning up the
existing ones.

Thanks.