git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sha1-file: make pretend_object_file() not prefetch

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 21, 2020, 23:27 UTC
Message-ID
<xmqq4kq078ks.fsf@gitster.c.googlers.com>
In-Reply-To
<20200721225020.1352772-1-jonathantanmy@google.com>
Jonathan Tan <jonathantanmy@google.com> writes:
Show 5 quoted lines
> When pretend_object_file() is invoked with an object that does not exist
> (as is the typical case), there is no need to fetch anything from the
> promisor remote, because the caller already knows what the object is
> supposed to contain. Therefore, suppress the fetch. (The
> OBJECT_INFO_QUICK flag is added for the same reason.)

Yes, "pretend" is also a way to lie about the contents IIRC, so even if the object is available elsewhere, we should *not* fetch from the promisor. Makes sense to me.

Previous: Junio C HamanoNext: Jeff King
Message 3 of 5 in “sha1-file: make pretend_object_file() not prefetch”
  1. sha1-file: make pretend_object_file() not prefetchJonathan Tan, Jul 21, 2020
  2. Junio C HamanoJul 21, 2020
  3. Junio C HamanoJul 21, 2020
  4. Jeff KingJul 23, 2020
  5. Junio C HamanoJul 23, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.