From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 21 Jul 2020 23:27:15 GMT
Subject: Re: [PATCH] sha1-file: make pretend_object_file() not prefetch
Message-ID: <xmqq4kq078ks.fsf@gitster.c.googlers.com>
In-Reply-To: <20200721225020.1352772-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

> When pretend_object_file() is invoked with an object that does not exist
> (as is the typical case), there is no need to fetch anything from the
> promisor remote, because the caller already knows what the object is
> supposed to contain. Therefore, suppress the fetch. (The
> OBJECT_INFO_QUICK flag is added for the same reason.)

Yes, "pretend" is also a way to lie about the contents IIRC, so even
if the object is available elsewhere, we should *not* fetch from the
promisor.  Makes sense to me.