Re: [PATCH] Optimize the description of the configuration in packfile-uris doc

From: Junio C Hamano <gitster@pobox.com>
Date: May 6, 2021, 21:39 UTC
Message-ID: <xmqq4kffy224.fsf@gitster.g>
In-Reply-To: <20210506164728.336409-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 12 quoted lines

>> There is a description problem in the document about packfile-uris. This
>> patch describes the configuration format of `uploadpack.blobPackfileUri`
>> more accurately.
>
> Thanks for noticing this. The diff itself is correct, of course.
>
> As for the commit message, limit the title to 50 characters or fewer if
> possible. Maybe something like "packfile-uri.txt: fix blobPackfileUri
> description" or something like that.
>
> Also in the commit message, maybe mention that the correct format can be
> seen in t5702.

Thanks for giving a review with clear suggestion for improvements, Jonathan. And thanks for contributing, Teng.

Will look forward to seeing an updated patch.