git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] packfile-uri.txt: fix blobPackfileUri description

From
Teng Long <dyroneteng@gmail.com>
Date
May 11, 2021, 06:45 UTC
Message-ID
<20210511064554.59924-1-dyroneteng@gmail.com>
In-Reply-To
<xmqq4kffy224.fsf@gitster.g>

Fix the 'uploadpack.blobPackfileUri' description in packfile-uri.txt and the correct format also can be seen in t5702.

Jonathan Tan <jonathantanmy@google.com> writes:
>As for the commit message, limit the title to 50 characters or fewer if
>possible. Maybe something like "packfile-uri.txt: fix blobPackfileUri
>description" or something like that.

Thanks for mention this, "packfile-uri.txt: fix blobPackfileUri description" is good and meets the "50 characters" requirement. So the title is modified.

>Also in the commit message, maybe mention that the correct format can be
>seen in t5702.

Because I am implementing another patch[1] about supporting the commit object in packfile-uri, I noticed the `configure_exclusion` function in t5702, which is now mentioned in the commit message.

[1]https://public-inbox.org/git/20210507021140.31372-1-dyroneteng@gmail.com
Signed-off-by: Teng Long <dyroneteng@gmail.com>
---
 Documentation/technical/packfile-uri.txt | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/Documentation/technical/packfile-uri.txt b/Documentation/technical/packfile-uri.txt
index f7eabc6c76..1eb525fe76 100644
--- a/Documentation/technical/packfile-uri.txt
+++ b/Documentation/technical/packfile-uri.txt
@@ -35,13 +35,14 @@ include some sort of non-trivial implementation in the Minimum Viable Product,
 at least so that we can test the client.
 
 This is the implementation: a feature, marked experimental, that allows the
-server to be configured by one or more `uploadpack.blobPackfileUri=<sha1>
-<uri>` entries. Whenever the list of objects to be sent is assembled, all such
-blobs are excluded, replaced with URIs. As noted in "Future work" below, the
-server can evolve in the future to support excluding other objects (or other
-implementations of servers could be made that support excluding other objects)
-without needing a protocol change, so clients should not expect that packfiles
-downloaded in this way only contain single blobs.
+server to be configured by one or more `uploadpack.blobPackfileUri=
+<object-hash> <pack-hash> <uri>` entries. Whenever the list of objects to be
+sent is assembled, all such blobs are excluded, replaced with URIs. As noted
+in "Future work" below, the server can evolve in the future to support
+excluding other objects (or other implementations of servers could be made
+that support excluding other objects) without needing a protocol change, so
+clients should not expect that packfiles downloaded in this way only contain
+single blobs.
 
 Client design
 -------------
-- 
2.31.1.443.g1f2fb5c85f.dirty
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 12 in “Optimize the description of the configuration in packfile-uris doc”
  1. Optimize the description of the configuration in packfile-uris docTeng Long, May 6, 2021
  2. Jonathan TanMay 6, 2021
  3. Junio C HamanoMay 6, 2021
  4. packfile-uri.txt: fix blobPackfileUri descriptionTeng Long, May 11, 2021
  5. Junio C HamanoMay 11, 2021
  6. Long TengMay 12, 2021
  7. Junio C HamanoMay 12, 2021
  8. packfile-uri.txt: fix blobPackfileUri descriptionTeng Long, May 13, 2021
  9. Junio C HamanoMay 13, 2021
  10. Junio C HamanoMay 18, 2021
  11. Jonathan TanMay 24, 2021
  12. Junio C HamanoMay 25, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.