git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Remove negation from the merge option "--no-verify"

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 27, 2021, 20:16 UTC
Message-ID
<xmqq4k92w7do.fsf@gitster.g>
In-Reply-To
<YXlTpzrY7KFqRlno@pflmari>
Alex Riesen <alexander.riesen@cetitec.com> writes:
Show 12 quoted lines
> From: Alex Riesen <raa.lkml@gmail.com>
>
> This allows re-enabling hooks disabled by an earlier "--no-verify"
> in command-line and makes the interface more consistent.
>
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
>
> ---
>
> This one is on top of "[PATCH] Fix "commit-msg" hook unexpectedly called for
> "git pull --no-verify" (http://public-inbox.org/git/YXfwanz3MynCLDmn@pflmari/).
> Which is a bit awkward. Should I resend as series?

Don't we need to do this at the root cause command "git commit"? It is documented to take "--no-verify" but not "--verify" to countermand an earlier "--no-verify" on the command line.

And yes, I agree that we shouldn't introduce an awkwardness in one step of the series and fix it in another step of the same series.

Previous: Alex RiesenNext: Alex Riesen
Message 8 of 22 in “Fix "commit-msg" hook unexpectedly called for "git pull --no-verify"”
  1. Fix "commit-msg" hook unexpectedly called for "git pull --no-verify"Alex Riesen, Oct 26, 2021
  2. Jeff KingOct 26, 2021
  3. Fix "commit-msg" hook unexpectedly called for "git pull --no-verify"Alex Riesen, Oct 27, 2021
  4. Jeff KingOct 27, 2021
  5. Alex RiesenOct 27, 2021
  6. Jeff KingOct 27, 2021
  7. Remove negation from the merge option "--no-verify"Alex Riesen, Oct 27, 2021
  8. Junio C HamanoOct 27, 2021
  9. Alex RiesenOct 28, 2021
  10. Remove negation from the commit and merge option "--no-verify"Alex Riesen, Oct 28, 2021
  11. Phillip WoodOct 28, 2021
  12. Alex RiesenOct 28, 2021
  13. 2/2 Fix "commit-msg" hook unexpectedly called for "git pull --no-verify"Alex Riesen, Oct 28, 2021
  14. Junio C HamanoOct 28, 2021
  15. Alex RiesenOct 28, 2021
  16. Junio C HamanoOct 28, 2021
  17. Alex RiesenOct 29, 2021
  18. Alex RiesenOct 28, 2021
  19. Phillip WoodOct 29, 2021
  20. Document positive variant of commit and merge option "--no-verify"Alex Riesen, Oct 29, 2021
  21. Phillip WoodNov 1, 2021
  22. Junio C HamanoOct 27, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.