git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test-lib: unset trace2 parent envvars

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 18, 2022, 21:50 UTC
Message-ID
<xmqq4k60sogk.fsf@gitster.g>
In-Reply-To
<Yecv7H5rrdMnRJBs@google.com>
Josh Steadmon <steadmon@google.com> writes:
> Yes, due to the number of different TRACE2 modes, I figured it was
> cleaner to allow them by default and then explicitly unset the ones that
> cause trouble for trace parsing tests.

I think I would agree that it is a better solution, and the design behind it (which makes me say it is better) should be recorded in the log message (and possibly in-code comment near the place we reset them) to help future developers who may add more TRACE2 variables.

Thanks.
Previous: Josh SteadmonNext: Josh Steadmon
Message 4 of 10 in “test-lib: unset trace2 parent envvars”
  1. test-lib: unset trace2 parent envvarsJosh Steadmon, Jan 14, 2022
  2. Junio C HamanoJan 14, 2022
  3. Josh SteadmonJan 18, 2022
  4. Junio C HamanoJan 18, 2022
  5. Josh SteadmonJan 26, 2022
  6. Taylor BlauJan 18, 2022
  7. test-lib: unset trace2 parent envvarsJosh Steadmon, Jan 26, 2022
  8. Ævar Arnfjörð BjarmasonJan 27, 2022
  9. Junio C HamanoJan 27, 2022
  10. Josh SteadmonFeb 1, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.