From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 18 Jan 2022 21:50:35 GMT
Subject: Re: [PATCH] test-lib: unset trace2 parent envvars
Message-ID: <xmqq4k60sogk.fsf@gitster.g>
In-Reply-To: <Yecv7H5rrdMnRJBs@google.com>

Josh Steadmon <steadmon@google.com> writes:

> Yes, due to the number of different TRACE2 modes, I figured it was
> cleaner to allow them by default and then explicitly unset the ones that
> cause trouble for trace parsing tests.

I think I would agree that it is a better solution, and the design
behind it (which makes me say it is better) should be recorded in
the log message (and possibly in-code comment near the place we
reset them) to help future developers who may add more TRACE2
variables.

Thanks.