git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] symbolic-ref: teach "--[no-]recurse" option

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 8, 2022, 04:20 UTC
Message-ID
<xmqq4jwfc5er.fsf@gitster.g>
In-Reply-To
<CAPig+cQZ_SehTLoFEtBf2Xv=8iw3-DkjQfP3R9J8kUm3DjkLBw@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 21 quoted lines
> On Fri, Oct 7, 2022 at 6:19 PM Junio C Hamano <gitster@pobox.com> wrote:
>> [...]
>> One thing that is slightly irritating, however, is that I do not
>> think there is a good way (other than "cat .git/HEAD") to learn that
>> you checked out 'maint' to get into that state.  Just like the output
>> of "git branch --show-current" shows above, "git symbolic-ref HEAD"
>> would report 'refs/heads/maint-2.38', bypassing the intermediate
>> symbolic ref at 'refs/heads/maint' that is pointed at by HEAD.
>>
>> The internal resolve_ref() API already has the necessary support for
>> stopping after resolving a single level of a symbolic-ref, and we
>> can expose it by adding a "--[no-]recurse" option to the command.
>>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> ---
>>  builtin/symbolic-ref.c  | 16 ++++++++++------
>>  t/t1401-symbolic-ref.sh | 14 ++++++++++++++
>>  2 files changed, 24 insertions(+), 6 deletions(-)
>
> Should this be accompanied by a documentation update or is the patch
> intended as an RFC?

It started its life as an RFC but I had an actual need during today's integration run ;-). Will try to come up with a documentation patch when I have time.

Thanks.
Previous: Eric SunshineNext: Junio C Hamano
Message 3 of 13 in “symbolic-ref: teach "--[no-]recurse" option”
  1. symbolic-ref: teach "--[no-]recurse" optionJunio C Hamano, Oct 7, 2022
  2. Eric SunshineOct 8, 2022
  3. Junio C HamanoOct 8, 2022
  4. symbolic-ref: teach "--[no-]recurse" optionJunio C Hamano, Oct 8, 2022
  5. Eric SunshineOct 8, 2022
  6. Junio C HamanoOct 9, 2022
  7. Bagas SanjayaOct 8, 2022
  8. Junio C HamanoOct 9, 2022
  9. Philip OakleyOct 8, 2022
  10. Philip OakleyOct 8, 2022
  11. Junio C HamanoOct 9, 2022
  12. Philip OakleyOct 11, 2022
  13. symbolic-ref: teach "--[no-]recurse" optionJunio C Hamano, Oct 9, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.