Re: [PATCH] symbolic-ref: teach "--[no-]recurse" option
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Oct 8, 2022, 03:35 UTC
- Message-ID
- <CAPig+cQZ_SehTLoFEtBf2Xv=8iw3-DkjQfP3R9J8kUm3DjkLBw@mail.gmail.com>
- In-Reply-To
- <xmqqleprcn08.fsf@gitster.g>
On Fri, Oct 7, 2022 at 6:19 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 17 quoted lines
> [...] > One thing that is slightly irritating, however, is that I do not > think there is a good way (other than "cat .git/HEAD") to learn that > you checked out 'maint' to get into that state. Just like the output > of "git branch --show-current" shows above, "git symbolic-ref HEAD" > would report 'refs/heads/maint-2.38', bypassing the intermediate > symbolic ref at 'refs/heads/maint' that is pointed at by HEAD. > > The internal resolve_ref() API already has the necessary support for > stopping after resolving a single level of a symbolic-ref, and we > can expose it by adding a "--[no-]recurse" option to the command. > > Signed-off-by: Junio C Hamano <gitster@pobox.com> > --- > builtin/symbolic-ref.c | 16 ++++++++++------ > t/t1401-symbolic-ref.sh | 14 ++++++++++++++ > 2 files changed, 24 insertions(+), 6 deletions(-)
Should this be accompanied by a documentation update or is the patch intended as an RFC?