git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 2/2] attr: add flag `--source` to work with tree-ish

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 13, 2023, 22:19 UTC
Message-ID
<xmqq4jsu13id.fsf@gitster.g>
In-Reply-To
<57f5957127ce3be2621445806f2f00857ac8b1aa.1673521102.git.karthik.188@gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
Show 9 quoted lines
> diff --git a/attr.h b/attr.h
> index 3fb40cced0..f4a2bedd68 100644
> --- a/attr.h
> +++ b/attr.h
> @@ -1,6 +1,8 @@
>  #ifndef ATTR_H
>  #define ATTR_H
>  
> +#include "hash.h"

You only want "struct object_id" declared. Why include the whole file?

Previous: Karthik NayakNext: Karthik Nayak
Message 4 of 6 in “check-attr: add support to work with tree-ish”
  1. 0/2 check-attr: add support to work with tree-ishKarthik Nayak, Jan 12, 2023
  2. 1/2 t0003: move setup for `--all` into new blockKarthik Nayak, Jan 12, 2023
  3. 2/2 attr: add flag `--source` to work with tree-ishKarthik Nayak, Jan 12, 2023
  4. Junio C HamanoJan 13, 2023
  5. Karthik NayakJan 14, 2023
  6. Phillip WoodJan 13, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.