Re: [PATCH v6 2/2] attr: add flag `--source` to work with tree-ish

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jan 14, 2023, 08:23 UTC
Message-ID: <CAOLa=ZRZDKqPq8ChZtD48207GxnjvqKPPvAJaUVOW8oKrRtGMw@mail.gmail.com>
In-Reply-To: <xmqq4jsu13id.fsf@gitster.g>

On Fri, Jan 13, 2023 at 11:19 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

>
> Karthik Nayak <karthik.188@gmail.com> writes:
>
> > diff --git a/attr.h b/attr.h
> > index 3fb40cced0..f4a2bedd68 100644
> > --- a/attr.h
> > +++ b/attr.h
> > @@ -1,6 +1,8 @@
> >  #ifndef ATTR_H
> >  #define ATTR_H
> >
> > +#include "hash.h"
>
> You only want "struct object_id" declared.  Why include the whole
> file?

I see, I should have just used your patch, will add this and Ævar's [0] suggestion and do a quick re-roll. Thanks!

[0]: https://lore.kernel.org/git/230112.86lem728ig.gmgdl@evledraar.gmail.com/