git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 0/1] Add lines to `git log --graph` to separate connected regions

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 7, 2024, 05:37 UTC
Message-ID
<xmqq4jcdivgw.fsf@gitster.g>
In-Reply-To
<CAPig+cQVQrrXrDqys-TyCqFynR6=pmbxs-NK-ca-s0K8mjADaA@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 27 quoted lines
>> This leads to a problem. Say there are two connected regions, each having two
>> commits, the graph would look like this:
>>
>> * a2
>> * a1
>> * b2
>> * b1
>>
>> which may lead to a misunderstanding that these four commits belong to the same
>> timeline, i.e. b2 is a parent of a1.
>>
>> This patchset adds a separator line between each pair of connected regions to
>> clarify that they are not actually connected:
>>
>> * a2
>> * a1
>> ---
>> * b2
>> * b1
>
> This sort of information which explains why the patch may be desirable
> is not only helpful to reviewers of the submission, but will be
> helpful to future readers of the patch once it becomes part of the
> project's permanent history (assuming it is accepted). However, the
> cover letter does not become part of the project's history (it exists
> only in the mailing list). As such, please move this discussion into
> the commit message of the patch itself.

True. But because we are doing graph, shouldn't we be able to do better? For example, you can draw the two lineage of histories on different columns and ...

       * a2
       * a1
     * b2
     * b1

... that way, you do not need to lose one line of precious vertical screen real estate.

Previous: Eric SunshineNext: Quang Lê Duy
Message 10 of 15 in “Add lines to `git log --graph` to separate connected regions”
  1. 0/1 Add lines to `git log --graph` to separate connected regionsLê Duy Quang, Apr 7, 2024
  2. 1/1 Add separator lines into `git log --graph`.Lê Duy Quang, Apr 7, 2024
  3. Eric SunshineApr 7, 2024
  4. Eric SunshineApr 7, 2024
  5. Quang Lê DuyApr 7, 2024
  6. Dragan SimicApr 7, 2024
  7. Quang Lê DuyApr 7, 2024
  8. Eric SunshineApr 7, 2024
  9. Eric SunshineApr 7, 2024
  10. Junio C HamanoApr 7, 2024
  11. Quang Lê DuyApr 7, 2024
  12. Dragan SimicApr 7, 2024
  13. Quang Lê DuyApr 7, 2024
  14. Dragan SimicApr 7, 2024
  15. Junio C HamanoApr 8, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.