Re: [RFC PATCH 1/1] Add separator lines into `git log --graph`.

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 7, 2024, 05:52 UTC
Message-ID: <CAPig+cSfpWaanknSqMGEza7rPhXwgQ0k3V9svfuBsZ_C2EaCmw@mail.gmail.com>
In-Reply-To: <CAPig+cROH8Ebu9CgR87-48+Rk0H3maN+dwB+Y-N2FTvy5shE1Q@mail.gmail.com>

On Sun, Apr 7, 2024 at 1:47 AM Eric Sunshine <sunshine@sunshineco.com> wrote:

> I'm not particularly a user of --graph, so I don't necessarily have an
> opinion about the utility of this change or its mechanics, but I can
> make a few observations to help you improve the patch to improve the
> chances of it being accepted.

I forgot to mention that application of your patch results in some warnings:

    % git am add-sep-lines.patch
    Applying: Add separator lines into `git log --graph`.
    .git/rebase-apply/patch:61: trailing whitespace.
    .git/rebase-apply/patch:147: trailing whitespace.
    .git/rebase-apply/patch:151: trailing whitespace.
    .git/rebase-apply/patch:160: trailing whitespace.
    warning: 4 lines add whitespace errors.