git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] add-patch: enforce only one-letter response to prompts

From
Junio C Hamano <gitster@pobox.com>
Date
May 22, 2024, 19:27 UTC
Message-ID
<xmqq4jap4pgh.fsf@gitster.g>
In-Reply-To
<e9f41db1-741c-413f-81ce-a86b1802e507@gmail.com>
Rubén Justo <rjusto@gmail.com> writes:
> Here, perhaps you want to do:
>
> 			err(s, _("Only one letter is expected, got '%s'"), s->answer.buf);

True. The end-user errors are reported with err() in the surrounding code.

I however was hoping that this can be based on v2.44.0, which predates 9d225b02 (add-patch: do not show UI messages on stderr, 2024-04-29), which makes the testing of it a bit cumbersome.

Previous: Rubén JustoNext: Junio C Hamano
Message 18 of 21 in “add-patch: response to unknown command”
  1. add-patch: response to unknown commandRubén Justo, May 21, 2024
  2. Patrick SteinhardtMay 21, 2024
  3. Rubén JustoMay 21, 2024
  4. Re* [PATCH] add-patch: response to unknown commandJunio C Hamano, May 21, 2024
  5. Taylor BlauMay 21, 2024
  6. Junio C HamanoMay 21, 2024
  7. add-patch: enforce only one-letter response to promptsJunio C Hamano, May 21, 2024
  8. Eric SunshineMay 21, 2024
  9. Junio C HamanoMay 22, 2024
  10. Dragan SimicMay 22, 2024
  11. Junio C HamanoMay 22, 2024
  12. Dragan SimicMay 22, 2024
  13. Junio C HamanoMay 22, 2024
  14. Patrick SteinhardtMay 22, 2024
  15. Junio C HamanoMay 22, 2024
  16. add-patch: enforce only one-letter response to promptsJunio C Hamano, May 22, 2024
  17. Rubén JustoMay 22, 2024
  18. Junio C HamanoMay 22, 2024
  19. add-patch: enforce only one-letter response to promptsJunio C Hamano, May 22, 2024
  20. Patrick SteinhardtMay 23, 2024
  21. Junio C HamanoMay 23, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.