Re: [PATCH] Fix unused-parameter warnings with NO_ICONV

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 2, 2024, 22:39 UTC
Message-ID: <xmqq4j5uku3l.fsf@gitster.g>
In-Reply-To: <20241002200140.2123584-1-mh@glandium.org>

Mike Hommey <mh@glandium.org> writes:

Show 7 quoted lines

> The jk/unused-parameters topic enabled -Wunused-parameter. Some code in
> some non-typical configuration lacked annotations.
>
> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---
>  utf8.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Thanks.

Show 15 quoted lines

> diff --git a/utf8.h b/utf8.h
> index fcd5167baf..cce299d274 100644
> --- a/utf8.h
> +++ b/utf8.h
> @@ -33,8 +33,9 @@ char *reencode_string_len(const char *in, size_t insz,
>  			  const char *in_encoding,
>  			  size_t *outsz);
>  #else
> -static inline char *reencode_string_len(const char *a, size_t b,
> -					const char *c, const char *d, size_t *e)
> +static inline char *reencode_string_len(const char *a UNUSED, size_t b UNUSED,
> +					const char *c UNUSED,
> +					const char *d UNUSED, size_t *e)
>  { if (e) *e = 0; return NULL; }
>  #endif