git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix unused-parameter warnings with NO_ICONV

From
Mike Hommey <mh@glandium.org>
Date
Oct 3, 2024, 21:02 UTC
Message-ID
<20241003210229.g4yzbs2xh276xmdk@glandium.org>
In-Reply-To
<20241002220118.GA2892418@coredump.intra.peff.net>
On Wed, Oct 02, 2024 at 06:01:18PM -0400, Jeff King wrote:
Show 10 quoted lines
> On Thu, Oct 03, 2024 at 05:01:40AM +0900, Mike Hommey wrote:
> 
> > The jk/unused-parameters topic enabled -Wunused-parameter. Some code in
> > some non-typical configuration lacked annotations.
> 
> Thanks, this looks good. I tried to catch compile-time variants like
> this, but I was mostly limited to what we build in CI.
> 
> Out of curiosity, what platform do you use that needs NO_ICONV (or is it
> just a preference)?

I'm just using parts of libgit.a and don't need the iconv support so I disable it. That avoids a dependency on the iconv dll on Windows.

Mike
Previous: Jeff KingNext: Junio C Hamano
Message 5 of 6 in “Fix unused-parameter warnings with NO_ICONV”
  1. Fix unused-parameter warnings with NO_ICONVMike Hommey, Oct 2, 2024
  2. Kristoffer HaugsbakkOct 2, 2024
  3. Fix unused-parameter warnings with NO_ICONVMike Hommey, Oct 2, 2024
  4. Jeff KingOct 2, 2024
  5. Mike HommeyOct 3, 2024
  6. Junio C HamanoOct 2, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.