Re: [Outreachy][PATCH v2] builtin/update-server-info: remove the_repository global variable

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 11, 2025, 16:35 UTC
Message-ID: <xmqq4j1030cz.fsf@gitster.g>
In-Reply-To: <Z6r_pqqP5vjJI-R5@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 12 quoted lines

> On Mon, Feb 10, 2025 at 11:40:30PM +0530, Usman Akinyemi wrote:
>> Remove the_repository global variable in favor of the repository
>> argument that gets passed in "builtin/update-server-info.c".
>> 
>> When `-h` is passed to the command outside a Git repository, the
>> `run_builtin()` will call the `cmd_update_server_info()` function
>> with `repo` set to NULL and then early in the function, "parse_options()"
>> call will give the options help and exit, without having to consult much
>> of the configuration file. So it is safe to omit reading the config when
>> `repo` argument the caller gave us is NULL.
>
> Thanks, this version looks good to me.

Yup, this looks good.

Thanks, both.