git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Outreachy][PATCH v2] builtin/update-server-info: remove the_repository global variable

From
Patrick Steinhardt <ps@pks.im>
Date
Feb 11, 2025, 07:43 UTC
Message-ID
<Z6r_pqqP5vjJI-R5@pks.im>
In-Reply-To
<20250210181103.3609495-1-usmanakinyemi202@gmail.com>
On Mon, Feb 10, 2025 at 11:40:30PM +0530, Usman Akinyemi wrote:
Show 9 quoted lines
> Remove the_repository global variable in favor of the repository
> argument that gets passed in "builtin/update-server-info.c".
> 
> When `-h` is passed to the command outside a Git repository, the
> `run_builtin()` will call the `cmd_update_server_info()` function
> with `repo` set to NULL and then early in the function, "parse_options()"
> call will give the options help and exit, without having to consult much
> of the configuration file. So it is safe to omit reading the config when
> `repo` argument the caller gave us is NULL.
Thanks, this version looks good to me.
Patrick
Previous: Usman AkinyemiNext: Junio C Hamano
Message 5 of 6 in “builtin/update-server-info: remove the_repository global variable”
  1. Usman AkinyemiFeb 10, 2025
  2. Junio C HamanoFeb 10, 2025
  3. Usman AkinyemiFeb 10, 2025
  4. [Outreachy][PATCH v2] builtin/update-server-info: remove the_repository global variableUsman Akinyemi, Feb 10, 2025
  5. Patrick SteinhardtFeb 11, 2025
  6. Junio C HamanoFeb 11, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.