Re: [PATCH 12/12] attr: enable incomplete-line whitespace error for this project
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 10, 2025, 18:40 UTC
- Message-ID
- <xmqq4ir120kd.fsf@gitster.g>
- In-Reply-To
- <e14d2d1f-f147-49dc-897d-87f0fbeaa275@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 18 quoted lines
> On 04/11/2025 02:09, Junio C Hamano wrote: >> Now "git diff --check" and "git apply --whitespace=warn/fix" learned >> incomplete line is a whitespace error, enable them for this project >> to prevent patches to add new incomplete lines to our sources. > > Makes sense > >> -*.[ch] whitespace=indent,trail,space diff=cpp >> -*.sh whitespace=indent,trail,space text eol=lf >> +*.[ch] whitespace=indent,trail,space,incomplete diff=cpp >> +*.sh whitespace=indent,trail,space,incomplete text eol=lf > > Do we want to check for incomplete lines in our documentation files as > well? > ... > This series does not update WS_DEFAULT_RULE to include > WS_INCOMPLETE_LINE so we will not detect incomplete lines unless we set > an attribute.
Yes, that is why I said "to our sources". The rest is left for somebody else to do, hopefully long after this series settles ;-)
Thanks.