Re: [PATCH v4 00/12] Incomplete lines

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Nov 14, 2025, 10:24 UTC
Message-ID: <dfdbfb71-2d3f-450e-bbcf-95ecbead3292@gmail.com>
In-Reply-To: <20251112220258.1009253-1-gitster@pobox.com>

On 12/11/2025 22:02, Junio C Hamano wrote:

Show 6 quoted lines

> Changes in v4:
> 
>   - The preliminary clean-up for "git diff" in [04/12] no longer
>     "corrects" the code that updates the line number upon seeing
>     "\ No newline" marker, and leaves it for later series to clean
>     it up as #leftoverbits.

I agree it makes sense to leave the existing increment alone as it's not really related to this series.

Show 5 quoted lines

>   - Our house rule updates in [12/12] now forbids the documentation
>     sources *.adoc to end in an incomplete line.
> 12:  068229790d ! 12:  cb86d9b45f attr: enable incomplete-line whitespace error for this project
>      +-/Documentation/**/*.adoc text eol=lf
>      ++/Documentation/**/*.adoc text eol=lf whitespace=!indent,trail,space,incomplete

Should that be "-indent" c.f. 358e94dc705 (.gitattributes: remove misspelled no-op whitespace attribute, 2025-11-11)

Thanks

Phillip