Re: [PATCH 06/11] bisect: handle NULL commit in `bisect_successful()`
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 10, 2026, 03:31 UTC
- Message-ID
- <xmqq4ii7h66f.fsf@gitster.g>
- In-Reply-To
- <704137510808ade246c6f1463e88a8e3041e0f7d.1783590159.git.gitgitgadget@gmail.com>
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 13 quoted lines
> diff --git a/builtin/bisect.c b/builtin/bisect.c
> index e7c2d2f3bb..6ff600c856 100644
> --- a/builtin/bisect.c
> +++ b/builtin/bisect.c
> @@ -663,6 +663,11 @@ static int bisect_successful(struct bisect_terms *terms)
>
> refs_read_ref(get_main_ref_store(the_repository), bad_ref, &oid);
> commit = lookup_commit_reference_by_name(bad_ref);
> + if (!commit) {
> + res = error(_("could not find commit for '%s'"), bad_ref);
> + free(bad_ref);
> + return res;
> + }Catching this case as an error is the right thing to do, but there is a bit of an impedance mismatch between the return value from error() and the status passed around in the bisect codebase.
The bisect.h header defines an enum bisect_error type, and I think the sole caller of this function, bisect_next(), expects to see BISECT_FAILED. It may happen to be the same -1 that error() returns, but for longer term maintainability, I would prefer to see it done more like:
error(_("..."));
free(bad_ref);
return BISECT_FAILED;or something along those lines.
Thanks.
> repo_format_commit_message(the_repository, commit, "%s", &commit_name, > &pp);