[PATCH v2 03/12] remote: guard `remote_tracking()` against NULL remote
- From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Jul 10, 2026, 11:39 UTC
- Message-ID
- <1398a2f1200da5cbc716b1a926aa614ef6c13503.1783683577.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.2174.v2.git.1783683577.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>
The `remote_tracking()` function unconditionally dereferences `remote->fetch` without checking whether remote is NULL.
In practice, this never happens because the only caller (`apply_cas()`) guards the calls to this function by checking the `use_tracking` and `use_tracking_for_rest` attributes.
However, it requires quite involved reasoning to reach that conclusion, and is therefore fragile. Just return -1 ("no tracking ref") when there is no remote to work with.
Pointed out by Coverity.
Assisted-by: Claude Opus 4.6 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- remote.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/remote.c b/remote.c index 00723b385e..887e388f9c 100644 --- a/remote.c +++ b/remote.c @@ -2681,6 +2681,8 @@ static int remote_tracking(struct remote *remote, const char *refname, { char *dst; + if (!remote) + BUG("remote_tracking() called with NULL remote"); dst = apply_refspecs(&remote->fetch, refname); if (!dst) return -1; /* no tracking ref for refname at remote */
-- gitgitgadget