git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] Good bye fnmatch

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 18, 2014, 19:28 UTC
Message-ID
<xmqq38jgfcft.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1392429709-9237-1-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
Show 7 quoted lines
> Long story short, we wanted globbing wildcard "**" so I ripped
> wildmatch library from rsync to do it. And it opened a possibility
> to replace fnmatch completely, which would provide consistent behavior
> across platforms (native fnmatch behaves differently on many corner
> cases), and some performance gains. I started fnmatch replacement with
> 4917e1e (Makefile: promote wildmatch to be the default fnmatch
> implementation - 2013-05-30). This is the final step.
Nice.
Show 30 quoted lines
>
> Nguyễn Thái Ngọc Duy (4):
>   Use wildmatch() directly without fnmatch() wrapper
>   Revert "test-wildmatch: add "perf" command to compare wildmatch and fnmatch"
>   Stop using fnmatch (either native or compat)
>   Actually remove compat fnmatch source code
>
>  Makefile                        |  22 --
>  builtin/apply.c                 |   2 +-
>  builtin/branch.c                |   2 +-
>  builtin/describe.c              |   2 +-
>  builtin/for-each-ref.c          |   2 +-
>  builtin/ls-remote.c             |   2 +-
>  builtin/name-rev.c              |   2 +-
>  builtin/reflog.c                |   2 +-
>  builtin/replace.c               |   2 +-
>  builtin/show-branch.c           |   2 +-
>  builtin/tag.c                   |   2 +-
>  compat/fnmatch/fnmatch.c (gone) | 494 ----------------------------------------
>  compat/fnmatch/fnmatch.h (gone) |  84 -------
>  config.mak.uname                |  10 -
>  configure.ac                    |  28 ---
>  diffcore-order.c                |   2 +-
>  dir.c                           |  11 +-
>  git-compat-util.h               |  12 -
>  refs.c                          |   2 +-
>  revision.c                      |   2 +-
>  t/t3070-wildmatch.sh            |  13 --
>  test-wildmatch.c                |  79 -------
>  22 files changed, 20 insertions(+), 759 deletions(-)
Previous: David Kastrup
Message 9 of 9 in “Good bye fnmatch”
  1. 0/4 Good bye fnmatchNguyễn Thái Ngọc Duy, Feb 15, 2014
  2. 1/4 Use wildmatch() directly without fnmatch() wrapperNguyễn Thái Ngọc Duy, Feb 15, 2014
  3. 2/4 Revert "test-wildmatch: add "perf" command to compare wildmatch and fnmatch"Nguyễn Thái Ngọc Duy, Feb 15, 2014
  4. 3/4 Stop using fnmatch (either native or compat)Nguyễn Thái Ngọc Duy, Feb 15, 2014
  5. 4/4 Actually remove compat fnmatch source codeNguyễn Thái Ngọc Duy, Feb 15, 2014
  6. David KastrupFeb 15, 2014
  7. Duy NguyenFeb 15, 2014
  8. David KastrupFeb 15, 2014
  9. Junio C HamanoFeb 18, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.