git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] Good bye fnmatch

From
David Kastrup <dak@gnu.org>
Date
Feb 15, 2014, 08:23 UTC
Message-ID
<8761og3htv.fsf@fencepost.gnu.org>
In-Reply-To
<1392429709-9237-1-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> Long story short, we wanted globbing wildcard "**" so I ripped
> wildmatch library from rsync to do it.

Since version 3.0.0, rsync is GPLv3 <URL:https://rsync.samba.org/GPL.html>. So be sure to take an older version.

Show 6 quoted lines
> And it opened a possibility to replace fnmatch completely, which would
> provide consistent behavior across platforms (native fnmatch behaves
> differently on many corner cases), and some performance gains. I
> started fnmatch replacement with 4917e1e (Makefile: promote wildmatch
> to be the default fnmatch implementation - 2013-05-30). This is the
> final step.

Sounds like I'm, uh, somewhat late in the game. More likely than not you've taken care of that aspect long ago. Just thought I'd mention it.

-- 
David Kastrup
Previous: Nguyễn Thái Ngọc DuyNext: Duy Nguyen
Message 6 of 9 in “Good bye fnmatch”
  1. 0/4 Good bye fnmatchNguyễn Thái Ngọc Duy, Feb 15, 2014
  2. 1/4 Use wildmatch() directly without fnmatch() wrapperNguyễn Thái Ngọc Duy, Feb 15, 2014
  3. 2/4 Revert "test-wildmatch: add "perf" command to compare wildmatch and fnmatch"Nguyễn Thái Ngọc Duy, Feb 15, 2014
  4. 3/4 Stop using fnmatch (either native or compat)Nguyễn Thái Ngọc Duy, Feb 15, 2014
  5. 4/4 Actually remove compat fnmatch source codeNguyễn Thái Ngọc Duy, Feb 15, 2014
  6. David KastrupFeb 15, 2014
  7. Duy NguyenFeb 15, 2014
  8. David KastrupFeb 15, 2014
  9. Junio C HamanoFeb 18, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.