Re: [PATCH v3 2/2] blame: use a helper to get suitable blame_date_width

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 21, 2014, 19:19 UTC
Message-ID: <xmqq38h6a3sk.fsf@gitster.dls.corp.google.com>
In-Reply-To: <xmqqfvl6a9ar.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> What I am wondering is if we can do something
> like this:
> ...

Nah, that is a lot more stupid than just doing

Show 22 quoted lines

>     In code:
>
>         blame_date_width = strtoul(_("4 years, 11 months ago"), NULL, 10) + 1;
>
>     In git.pot:
>
>         #. This string is used to tell us the maximum display width for a
>         #. relative timestamp in "git blame" output.  For C locale, "4 years,
>         #. 11 months ago", which takes 22 places, is the longest among various
>         #. forms of relative timestamps, but your language may need more or
>         #. fewer display columns.
>         msgid "4 years, 11 months ago"
>         msgstr ""
>
>     In de.po:
>         #. This string is used to tell us the maximum display width for a
>         #. relative timestamp in "git blame" output.  For C locale, "4 years,
>         #. 11 months ago", which takes 22 places, is the longest among various
>         #. forms of relative timestamps, but your language may need more or
>         #. fewer display columns.
>         msgid "4 years, 11 months ago"
>         msgstr ""vor 4 Jahren, und 11 Monaten"

which is essentially how your very original looked like (modulo the comments). So let's not try to be clever or cute, and just have a good instruction in the TRANSLATORS comments.

Sorry for flipping and flopping on this one.