git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/2] blame: use a helper to get suitable blame_date_width

From
Jiang Xin <worldhello.net@gmail.com>
Date
Apr 22, 2014, 12:25 UTC
Message-ID
<CANYiYbGjyEHD_VC4jWVt5dvb6x2aCwpydmvKO9kwh5OW26iAMg@mail.gmail.com>
In-Reply-To
<xmqq38h6a3sk.fsf@gitster.dls.corp.google.com>
2014-04-22 3:19 GMT+08:00 Junio C Hamano <gitster@pobox.com>:
Show 36 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> What I am wondering is if we can do something
>> like this:
>> ...
>
> Nah, that is a lot more stupid than just doing
>
>>     In code:
>>
>>         blame_date_width = strtoul(_("4 years, 11 months ago"), NULL, 10) + 1;
>>
>>     In git.pot:
>>
>>         #. This string is used to tell us the maximum display width for a
>>         #. relative timestamp in "git blame" output.  For C locale, "4 years,
>>         #. 11 months ago", which takes 22 places, is the longest among various
>>         #. forms of relative timestamps, but your language may need more or
>>         #. fewer display columns.
>>         msgid "4 years, 11 months ago"
>>         msgstr ""
>>
>>     In de.po:
>>         #. This string is used to tell us the maximum display width for a
>>         #. relative timestamp in "git blame" output.  For C locale, "4 years,
>>         #. 11 months ago", which takes 22 places, is the longest among various
>>         #. forms of relative timestamps, but your language may need more or
>>         #. fewer display columns.
>>         msgid "4 years, 11 months ago"
>>         msgstr ""vor 4 Jahren, und 11 Monaten"
>
> which is essentially how your very original looked like (modulo the
> comments).  So let's not try to be clever or cute, and just have a
> good instruction in the TRANSLATORS comments.
>
> Sorry for flipping and flopping on this one.

I will send patch v4 tonight, and I think all l10n team leaders should pay attention to this thread:

 * http://thread.gmane.org/gmane.comp.version-control.git/246464
-- 
Jiang Xin
Previous: Junio C HamanoNext: Jiang Xin
Message 15 of 20 in “blame: add correct paddings in time_buf for align”
  1. blame: add correct paddings in time_buf for alignJiang Xin, Apr 18, 2014
  2. Duy NguyenApr 18, 2014
  3. Junio C HamanoApr 18, 2014
  4. Duy NguyenApr 19, 2014
  5. 0/2 peroper align of datetime filed of git-blameJiang Xin, Apr 20, 2014
  6. 1/2 bugfix: fix broken time_buf paddings for git-blameJiang Xin, Apr 20, 2014
  7. Eric SunshineApr 20, 2014
  8. 2/2 blame: use different blame_date_width for different localeJiang Xin, Apr 20, 2014
  9. Junio C HamanoApr 20, 2014
  10. 0/2 peroper align of datetime filed of git-blameJiang Xin, Apr 21, 2014
  11. 1/2 bugfix: fix broken time_buf paddings for git-blameJiang Xin, Apr 21, 2014
  12. 2/2 blame: use a helper to get suitable blame_date_widthJiang Xin, Apr 21, 2014
  13. Junio C HamanoApr 21, 2014
  14. Junio C HamanoApr 21, 2014
  15. Jiang XinApr 22, 2014
  16. 0/2 peroper align of datetime filed of git-blameJiang Xin, Apr 22, 2014
  17. 1/2 bugfix: fix broken time_buf paddings for git-blameJiang Xin, Apr 22, 2014
  18. 2/2 blame: dynamic blame_date_width for different localesJiang Xin, Apr 22, 2014
  19. David KastrupApr 22, 2014
  20. Jiang XinApr 22, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.