Re: [PATCH v3 2/2] blame: use a helper to get suitable blame_date_width
- From
Jiang Xin <worldhello.net@gmail.com>
- Date
- Apr 22, 2014, 12:25 UTC
- Message-ID
- <CANYiYbGjyEHD_VC4jWVt5dvb6x2aCwpydmvKO9kwh5OW26iAMg@mail.gmail.com>
- In-Reply-To
- <xmqq38h6a3sk.fsf@gitster.dls.corp.google.com>
2014-04-22 3:19 GMT+08:00 Junio C Hamano <gitster@pobox.com>:
Show 36 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> What I am wondering is if we can do something
>> like this:
>> ...
>
> Nah, that is a lot more stupid than just doing
>
>> In code:
>>
>> blame_date_width = strtoul(_("4 years, 11 months ago"), NULL, 10) + 1;
>>
>> In git.pot:
>>
>> #. This string is used to tell us the maximum display width for a
>> #. relative timestamp in "git blame" output. For C locale, "4 years,
>> #. 11 months ago", which takes 22 places, is the longest among various
>> #. forms of relative timestamps, but your language may need more or
>> #. fewer display columns.
>> msgid "4 years, 11 months ago"
>> msgstr ""
>>
>> In de.po:
>> #. This string is used to tell us the maximum display width for a
>> #. relative timestamp in "git blame" output. For C locale, "4 years,
>> #. 11 months ago", which takes 22 places, is the longest among various
>> #. forms of relative timestamps, but your language may need more or
>> #. fewer display columns.
>> msgid "4 years, 11 months ago"
>> msgstr ""vor 4 Jahren, und 11 Monaten"
>
> which is essentially how your very original looked like (modulo the
> comments). So let's not try to be clever or cute, and just have a
> good instruction in the TRANSLATORS comments.
>
> Sorry for flipping and flopping on this one.I will send patch v4 tonight, and I think all l10n team leaders should pay attention to this thread:
* http://thread.gmane.org/gmane.comp.version-control.git/246464
-- Jiang Xin