Re: --trust-exit-code not working

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 14, 2014, 20:41 UTC
Message-ID: <xmqq389l347n.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20141114161235.GA30086@vimeitor>

David, I think this is about your 2b52123f (difftool: add support for --trust-exit-code, 2014-10-26). If you have time can you help Adria?

Thanks.

Adria Farres <14farresa@gmail.com> writes:

Show 18 quoted lines

> Hello!,
>
> I sent an email last week, but I'm not sure if I sent it incorrectly, or the
> formatting was very bad, or it went unnoticed. A few days ago a great soul was
> kind enough to create the --trust-exit-code option that made git respect the
> exit code of the difftool. Unfortunately, I haven't been able to make it work.
> Exiting vimdiff with :cq doesn't seem to make git quit, as it keeps pushing new
> files to be diffed. I tried meld and the exact same thing. I'm confident that
> exiting with :cq gives an error, as I have checked it, and I'm using git
> 2.2.0.rc1.
>
> Am I missing something important? Has anyone managed to make it work with
> vimdiff and meld? Sorry for bringing that up so late and for being a
> disturbance.
>
> Thank you,
>
> Adria