Re: --trust-exit-code not working

From: David Aguilar <davvid@gmail.com>
Date: Nov 14, 2014, 21:55 UTC
Message-ID: <20141114215527.GA93845@gmail.com>
In-Reply-To: <20141114161235.GA30086@vimeitor>

On Fri, Nov 14, 2014 at 05:12:35PM +0100, Adria Farres wrote:

> Hello!,
> 
> I sent an email last week, but I'm not sure if I sent it incorrectly, or the
> formatting was very bad, or it went unnoticed. A few days ago a great soul was

Nah, I was just very busy and it slipped through the cracks. Sorry 'bout that ~ I was meaning to get back to it.

Show 12 quoted lines

> kind enough to create the --trust-exit-code option that made git respect the
> exit code of the difftool. Unfortunately, I haven't been able to make it work.
> Exiting vimdiff with :cq doesn't seem to make git quit, as it keeps pushing new
> files to be diffed. I tried meld and the exact same thing. I'm confident that
> exiting with :cq gives an error, as I have checked it, and I'm using git
> 2.2.0.rc1.
> 
> Am I missing something important? Has anyone managed to make it work with
> vimdiff and meld? Sorry for bringing that up so late and for being a
> disturbance.
> 
> Thank you,

Thanks for testing, Adria.

If you could test my new patch we would very much appreciate it; adding a Tested-by: attribution line to the commit with your name would be very nice.

cheers,

-- 
David