git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 19, 2015, 17:54 UTC
Message-ID
<xmqq386123df.fsf@gitster.dls.corp.google.com>
In-Reply-To
<54E61285.5070600@web.de>
Torsten Bögershausen <tboegi@web.de> writes:
Show 24 quoted lines
> On 02/18/2015 07:40 PM, Junio C Hamano wrote:
>> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>>
>>> I understand that this used to work, but it probably shouldn't have
>>> ever been accepted.  It's nonstandard, and if we accept it for ssh,
>>> people will want it to work for https, and due to libcurl, it simply
>>> won't.
>>>
>>> I prefer to see our past acceptance of this format as a bug.  This is
>>> the first that I've heard of anyone noticing this (since 2013), so it
>>> can't be in common usage.
>>>
>>> If we accept it, we should explicitly document it as being deprecated
>>> and note that it's inconsistent with the way everything else works.
>> I was reviewing my Undecided pile today, and I think your objection
>> makes sense.
>>
>> Either of you care to update documentation, please, before I drop
>> this series and forget about it?
>
> The URL RFC is much stricter regarding which characters that are allowed
> in which part of the URL, as least as I read it.
> ...
> I'm somewhat unsure what to write in the documentation, I must admit.

I can see that you do not agree with the "If we accept it" part (where "it" refers to "allowing [...] was a bug.")---past acceptance was not a bug for you.

Brian is for that "If we accept it", and sees it as a bug.

So let's see what he comes up with as a follow-up to the "we should explicitly document it" part.

Previous: Torsten BögershausenNext: brian m. carlson
Message 7 of 9 in “connect.c: Improve parsing of literal IPV6 addresses”
  1. 1/3 connect.c: Improve parsing of literal IPV6 addressesTorsten Bögershausen, Jan 19, 2015
  2. brian m. carlsonJan 22, 2015
  3. Torsten BögershausenJan 22, 2015
  4. brian m. carlsonJan 22, 2015
  5. Junio C HamanoFeb 18, 2015
  6. Torsten BögershausenFeb 19, 2015
  7. Junio C HamanoFeb 19, 2015
  8. brian m. carlsonFeb 19, 2015
  9. Torsten BögershausenFeb 20, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.