Re: [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Feb 19, 2015, 19:40 UTC
Message-ID: <20150219194050.GA5021@vauxhall.crustytoothpaste.net>
In-Reply-To: <xmqq386123df.fsf@gitster.dls.corp.google.com>

On Thu, Feb 19, 2015 at 09:54:52AM -0800, Junio C Hamano wrote:

Show 8 quoted lines

>I can see that you do not agree with the "If we accept it" part
>(where "it" refers to "allowing [...] was a bug.")---past acceptance
>was not a bug for you.
>
>Brian is for that "If we accept it", and sees it as a bug.
>
>So let's see what he comes up with as a follow-up to the "we should
>explicitly document it" part.

Here's what I propose:

-- >8 --
Subject: [PATCH] Documentation: note deprecated syntax for IPv6 SSH URLs

We have historically accepted some invalid syntax for SSH URLs containing IPv6 literals. Older versions of Git accepted URLs missing the brackets required by RFC 2732. Note that this behavior is deprecated and that other protocol handlers will not accept this syntax.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 Documentation/urls.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/urls.txt b/Documentation/urls.txt
index 9ccb246..2c1a84f 100644
--- a/Documentation/urls.txt
+++ b/Documentation/urls.txt
@@ -38,6 +38,10 @@ The ssh and git protocols additionally support ~username expansion:
 - git://host.xz{startsb}:port{endsb}/~{startsb}user{endsb}/path/to/repo.git/
 - {startsb}user@{endsb}host.xz:/~{startsb}user{endsb}/path/to/repo.git/
 
+For backwards compatibility reasons, Git, when using ssh URLs, accepts
+some URLs containing IPv6 literals that are missing the brackets. This
+syntax is deprecated, and other protocol handlers do not permit this.
+
 For local repositories, also supported by Git natively, the following
 syntaxes may be used:

-- 
2.2.1.209.g41e5f3a