Re: [PATCH] t5516-fetch-push: Correct misspelled pushInsteadOf

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 2, 2015, 19:43 UTC
Message-ID: <xmqq385nb2yg.fsf@gitster.dls.corp.google.com>
In-Reply-To: <alpine.DEB.2.10.1502282316150.7008@buzzword-bingo.mit.edu>

Anders Kaseorg <andersk@mit.edu> writes:

Show 18 quoted lines

> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
> ---
>  t/t5516-fetch-push.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh
> index 85c7fec..594d7a6 100755
> --- a/t/t5516-fetch-push.sh
> +++ b/t/t5516-fetch-push.sh
> @@ -238,7 +238,7 @@ test_expect_success 'push with pushInsteadOf' '
>  test_expect_success 'push with pushInsteadOf and explicit pushurl (pushInsteadOf should not rewrite)' '
>  	mk_empty testrepo &&
>  	test_config "url.trash2/.pushInsteadOf" testrepo/ &&
> -	test_config "url.trash3/.pusnInsteadOf" trash/wrong &&
> +	test_config "url.trash3/.pushInsteadOf" trash/wrong &&
>  	test_config remote.r.url trash/wrong &&
>  	test_config remote.r.pushurl "testrepo/" &&
>  	git push r refs/heads/master:refs/remotes/origin/master &&

Interesting.

Now an obvious and natural question after seeing this change is how the original test passed with misspelled configuration. Is a test that pushes into "trash/wrong" checking the right outcome? If the reason why the existing tests passed without this patch is because they do not test the right thing, then shouldn't they be corrected together with the above fix?